Adding missing @Override annotations. Some refactoring - #45
Conversation
|
@claude review pr with inline comments |
|
Claude finished @unv-unv's task in 4m 33s —— View job PR Review: Adding missing @OverRide annotations, refactoringI reviewed the full diff ( The only recurring issue is cosmetic: mixed tabs vs. spaces. Several tab-indented files received new lines/blocks indented with spaces (the reformatting looks like it was done with a spaces-configured formatter). I left inline comments (with one-click
Inline comments left:
Overall: 👍 Good, low-risk cleanup. Recommend normalizing the tab/space indentation on the reformatted blocks before merge (ideally by pointing the IDE/formatter at tabs for these files); everything else looks correct.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public abstract boolean isRemote(); | ||
|
|
||
| @Nonnull | ||
| @Override |
There was a problem hiding this comment.
This @Override is indented with 4 spaces, but the rest of this file is tab-indented (the @Nonnull line just above uses a tab). The same tab/space mismatch recurs on several other reformatted lines in this PR (see notes on GitSSHXmlRpcClient and SSHMain). Suggest keeping each file consistent with its existing indentation.
| @Override | |
| @Override |
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
The added @Override and the reformatted method signature/parameters below it are indented with spaces, while this file uses tabs. Recommend re-indenting this block — and the analogous askPassphrase / replyToChallenge / askPassword blocks in this file — with tabs so the whole file stays consistent.
| }; | ||
| @SuppressWarnings({"HardCodedStringLiteral"}) final Thread t = new Thread(action, "Forwarding " + name); | ||
| Runnable action = () -> { | ||
| byte[] buffer = new byte[BUFFER_SIZE]; |
There was a problem hiding this comment.
Nice conversion of the anonymous Runnable to a lambda. One nit: the lambda body is indented with spaces, whereas the enclosing method uses tabs. Re-indenting the body with tabs would keep this file consistent.
| */ | ||
| @SuppressWarnings({"UseOfObsoleteCollectionType"}) | ||
| @Override | ||
| @SuppressWarnings({"UseOfObsoleteCollectionType"}) |
There was a problem hiding this comment.
This @SuppressWarnings line is space-indented while the surrounding @Override / @Nullable lines use tabs.
| @SuppressWarnings({"UseOfObsoleteCollectionType"}) | |
| @SuppressWarnings({"UseOfObsoleteCollectionType"}) |
| @Override | ||
| public int compareTo(GitReference o) { | ||
| return o == null ? 1 : StringUtil.compare(getFullName(), o.getFullName(), SystemInfo.isFileSystemCaseSensitive); | ||
| return o == null ? 1 : StringUtil.compare(getFullName(), o.getFullName(), Platform.current().fs().isCaseSensitive()); |
There was a problem hiding this comment.
Good move off the deprecated SystemInfo. Worth one confirmation on semantics: SystemInfo.isFileSystemCaseSensitive reflected the case-sensitivity of the filesystem the IDE runs on, and Platform.current().fs().isCaseSensitive() should be its intended replacement. Since this value drives Git reference name comparison, a quick check that the two are truly equivalent is worthwhile.
2 participants
No description provided.