Skip to content

fix: resolve Snyk-flagged vulnerabilities in dependency overrides [EXP-1311] - #40

Merged
rohan-naik merged 1 commit into
mainfrom
EXP-1311
Aug 14, 2026
Merged

fix: resolve Snyk-flagged vulnerabilities in dependency overrides [EXP-1311]#40
rohan-naik merged 1 commit into
mainfrom
EXP-1311

Conversation

@rohan-naik

Copy link
Copy Markdown
Contributor

Summary

Remediates the Snyk-flagged dependency vulnerabilities tracked in EXP-1311.

  • Bumped brace-expansion 5.0.75.0.9 (scoped under the @contentstack/venus-components override)
  • Bumped dompurify 3.4.13.4.13
  • Regenerated package-lock.json so the lockfile reflects the pinned resolutions

Context

The lockfile had drifted out of sync with the overrides block. Since Snyk builds its dependency graph from the lockfile, snyk test was aborting with an opaque An unknown error occurred rather than reporting findings — so the scan had to be unblocked before the vulnerabilities could be confirmed cleared.

The bulk of the package-lock.json diff is transitive bumps that resolved within existing semver ranges during regeneration (mostly @babel/* patch releases); no direct dependency ranges were widened.

Verification

npx snyk test passes against the regenerated lockfile:

Organization:      contentstack-venus
Package manager:   npm
Target file:       package-lock.json
Project name:      @contentstack/rte-plugin-boilerplate

✔ Tested 357 dependencies for known issues, no vulnerable paths found.

Notes for reviewers

Two things worth a look:

  1. The brace-expansion override is nested under @contentstack/venus-components, which does not pull brace-expansion anywhere in the current tree — so that entry is effectively inert. The brace-expansion copies that actually resolve come from minimatch, rimraf, and tslint (dev tooling) at 2.1.4 / 1.1.18, both already past the ReDoS advisory. If the intent was a global pin, the entry belongs at the top level of overrides alongside dompurify.
  2. npm audit still reports 8 issues (7 moderate, 1 high) that Snyk does not flag — the two tools use different advisory databases and severity thresholds. Out of scope here; happy to open a follow-up if we want those addressed.

🤖 Generated with Claude Code

Bump brace-expansion to 5.0.9 and dompurify to 3.4.13 in the overrides
block, and regenerate package-lock.json so the lockfile reflects the
pinned resolutions. The stale lockfile was also causing `snyk test` to
abort with an unknown error rather than report results.

`snyk test` now passes: 357 dependencies tested, no vulnerable paths found.

EXP-1311

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@rohan-naik
rohan-naik requested a review from a team as a code owner August 14, 2026 06:10
@snyk-io

snyk-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@rohan-naik
rohan-naik merged commit 4bb117b into main Aug 14, 2026
10 checks passed
@rohan-naik
rohan-naik deleted the EXP-1311 branch August 14, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants