Fix spec drifting in the design document - #82
Open
fedgiac wants to merge 1 commit into
Open
Conversation
kaze-cow
approved these changes
Jul 30, 2026
tilacog
approved these changes
Jul 30, 2026
tilacog
left a comment
tilacog
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left a question.
| Buffer accounts are token accounts that hold funds on behalf of the settlement contract. | ||
|
|
||
| These token accounts are accessible to all solvers and effectively work like the current buffers. They are used to collect user funds, send out funds to the user, and collect fees, which stay on the buffers after the settlement. This means that the current fee accounting and withdrawal mechanism would be based on balance changes (like on Ethereum). | ||
| These token accounts are accessible to all solvers and effectively work like the current buffers. They are used to send out funds to the user and collect fees, which stay on the buffers after the settlement. This means that the current fee accounting and withdrawal mechanism would be based on balance changes (like on Ethereum). |
Contributor
There was a problem hiding this comment.
Just to confirm: buffer accounts are still used to Pull funds from users, right?
Contributor
Author
There was a problem hiding this comment.
Not really: BeginSettle allows solvers to specify where to send the funds. This could be any arbitrary account, and so they don't need to even specify the sell token buffer account in the list of accounts. But if a solver wants, then the buffers can be used, so if they need it for some reason they can work with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made a few design changes and the specs drifted a bit. This PR remedies that.
How to review
Make sure the changes match your current understanding of what we want to do.