Make account creation idempotent where necessary - #85
Open
fedgiac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.
Introduce idempotent PDA creation so two parties racing to create the same canonical account don't step on each other's toes, especially when multiple PDAs are created in the same transaction. This happens during an auction when solvers concurrently create the same token buffer, or the same partially-fillable order from a signature.
With these changes, the loser of the race succeeds as a no-op instead of reverting with the system program's
AccountAlreadyInUse.All three creation sites that went through
CanonicalPda::createnow split into two methods over the same allocation:create_idempotent: this is for order and buffer creation.create_new: this is for state PDA creation.How to test
New/updated tests in CI.