[ub:expr.shift.neg.and.width] Use std::uint32_t instead of int in example#9187
Closed
eisenwave wants to merge 1 commit into
Closed
[ub:expr.shift.neg.and.width] Use std::uint32_t instead of int in example#9187eisenwave wants to merge 1 commit into
eisenwave wants to merge 1 commit into
Conversation
notadragon
reviewed
Jul 16, 2026
Contributor
There was a problem hiding this comment.
We should have the #include <cstdint>. I would also prefer that we roll this into https://isocpp.org/files/papers/D4284R0.pdf for discoverability, but otherwise this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, I find it unnatural to use
intand then have to assert various properties to get 32-bit type.Secondly, the example is incorrect (well, not really, it's still true that a 32-bit shift is UB) because
sizeof(int) == 4 && CHAR_BIT == 8is not a sufficient assertion. It's possible thatintis a 16-bit type, with two 8-bit padding bytes and two 8-bit value bytes.Alternatively, we could also use
numeric_limits<int>::digitsin the assertion or just put the assumption about the width ofintinto prose.