docs(tcp_server): reference set_workers, not the constructor, in start()#320
Merged
Merged
Conversation
…t() (cppalliance#302) The start() precondition told users to provide workers "to the constructor", but the tcp_server constructor takes only ctx and ex; workers are installed via set_workers(). Align the docstring with the actual API, matching every other doc location.
|
An automated preview of the documentation is available at https://320.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-07-17 16:01:59 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
========================================
Coverage 77.79% 77.79%
========================================
Files 96 96
Lines 6985 6985
Branches 1682 1682
========================================
Hits 5434 5434
Misses 1055 1055
Partials 496 496
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start() precondition told users to provide workers "to the constructor", but the tcp_server constructor takes only ctx and ex; workers are installed via set_workers(). Align the docstring with the actual API, matching every other doc location.