Skip to content

refactor: trim over-broad models/init.py exports#135

Merged
wpak-ai merged 1 commit into
masterfrom
refactor/trim-model-exports
Jul 16, 2026
Merged

refactor: trim over-broad models/init.py exports#135
wpak-ai merged 1 commit into
masterfrom
refactor/trim-model-exports

Conversation

@clean6378-max-it

@clean6378-max-it clean6378-max-it commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Closes #131

models/init.py still exported BubbleRole and BubbleMetadata from models.bubble_display, even though they are low-level typed dict / literal types, not domain models. pr #118 dropped one test-only re-export; this finishes the trim so the package surface is Bubble, Composer, Workspace, SearchResult, SchemaError, and the rest of the domain types.

this pr removes BubbleRole and BubbleMetadata from all (15 names down to 13) and repoints the three in-repo callers to from models.bubble_display import .... DisplayBubble stays on the public models surface. no code moves, no runtime change.

to verify, run pytest -q and mypy --strict .. from models import BubbleRole should raise ImportError; from models.bubble_display import BubbleRole should work.

Summary by CodeRabbit

  • Refactor
    • Adjusted how bubble-related metadata and role types are imported within the project to better align with their dedicated locations.
    • Reduced package-level public exports for bubble metadata and role types.
    • Retained existing application behavior and functionality.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18c83ca0-9222-4710-9507-6b0e3d361e60

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8a38c and 99de171.

📒 Files selected for processing (4)
  • models/__init__.py
  • services/workspace_tabs.py
  • utils/cursor_md_exporter.py
  • utils/display_bubble.py
🚧 Files skipped from review as they are similar to previous changes (3)
  • utils/cursor_md_exporter.py
  • models/init.py
  • utils/display_bubble.py

📝 Walkthrough

Walkthrough

The package-level exports for BubbleMetadata and BubbleRole were removed, and internal modules now import them directly from models.bubble_display.

Changes

Bubble export cleanup

Layer / File(s) Summary
Trim package exports
models/__init__.py
Removes BubbleMetadata and BubbleRole from package-level imports and __all__.
Repoint internal imports
services/workspace_tabs.py, utils/cursor_md_exporter.py, utils/display_bubble.py
Imports the removed names directly from models.bubble_display while retaining other imports from models.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: bradjin8

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: trimming over-broad exports from models/init.py.
Linked Issues check ✅ Passed The PR trims all and repoints in-repository BubbleRole/BubbleMetadata imports to models.bubble_display as requested.
Out of Scope Changes check ✅ Passed The changes stay within export-surface cleanup and import rewiring, with no unrelated code paths or behavior changes shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/trim-model-exports

Comment @coderabbitai help to get the list of available commands.

@clean6378-max-it clean6378-max-it self-assigned this Jul 15, 2026
@clean6378-max-it
clean6378-max-it force-pushed the refactor/trim-model-exports branch from 1f8a38c to 99de171 Compare July 16, 2026 14:40
@bradjin8
bradjin8 requested a review from wpak-ai July 16, 2026 16:16
@wpak-ai
wpak-ai merged commit f1605a8 into master Jul 16, 2026
17 checks passed
@wpak-ai
wpak-ai deleted the refactor/trim-model-exports branch July 16, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cppa-cursor-browser: trim over-broad models/__init__.py exports

3 participants