Fix #13148 FN: constStatement (static_cast<void>(integer|nullptr|NULL))#8694
Open
chrchr-github wants to merge 4 commits into
Open
Fix #13148 FN: constStatement (static_cast<void>(integer|nullptr|NULL))#8694chrchr-github wants to merge 4 commits into
chrchr-github wants to merge 4 commits into
Conversation
danmar
reviewed
Jul 11, 2026
| ASSERT_EQUALS("", errout_str()); | ||
|
|
||
| check("void f() { (void*)0; }"); | ||
| ASSERT_EQUALS("[test.cpp:1:12]: (warning) Redundant code: Found a statement that begins with numeric constant. [constStatement]\n", errout_str()); |
Collaborator
There was a problem hiding this comment.
hmm.. the warning message is not technically correct. I would say that the cast comes before the numeric constant.
maybe we should try to reformulate this somehow.
| " (void)NULL;\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("[test.cpp:2:22]: (warning) Redundant code: Found a statement that begins with numeric constant. [constStatement]\n" | ||
| "[test.cpp:3:22]: (warning) Redundant code: Found a statement that begins with NULL constant. [constStatement]\n" |
Collaborator
There was a problem hiding this comment.
Ideally we would not say that nullptr ist a NULL constant. can we write nullptr instead or null?
| "}\n"); | ||
| ASSERT_EQUALS("[test.cpp:2:22]: (warning) Redundant code: Found a statement that begins with numeric constant. [constStatement]\n" | ||
| "[test.cpp:3:22]: (warning) Redundant code: Found a statement that begins with NULL constant. [constStatement]\n" | ||
| "[test.cpp:4:5]: (warning) Redundant code: Found a statement that begins with NULL constant. [constStatement]\n", |
Collaborator
There was a problem hiding this comment.
In this test case it just looks like a redundant statement , I wonder if the severity should be "style" instead. Are there bugs discovered by this checker or just code cleanup?
We could change the severity in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.