Fix #684: Keep line directives in tokenized output#685
Open
glankk wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
There are some issues with how simplecpp currently handles directives and locations with respect to lines. The This won't be the case after this change because the line directives are kept in the raw tokens, but I think that's alright because I don't think this is inteded to begin with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lineDirectivefunction is not really needed after this change and has been removed. Alocationchangeflag has been added to theTokenclass to keep track of when a location discontinuity occurs, this is needed forgotoNextLineto still work correctly during preprocessing when#linemoves back to the same line it is already at.