CQL Test Server Updates - #377
Conversation
- Represent numeric intervals as Ranges - Fix range conversion bug for boundaries whose value is 0 - Add default unit '1' to numeric range quantities - Update dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 59 59
Lines 4933 4933
Branches 1429 1429
=======================================
Hits 4376 4376
Misses 322 322
Partials 235 235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dehall
left a comment
There was a problem hiding this comment.
This looks good to me!
I'm not super familiar with the tests-runner "ecosystem" so I confirmed this works better with the mitre-wip branch, but it still works with the current main. Or at least, nothing is obviously broken. (I know we're hoping to get a new cql-execution release out soon so that we can show off updated results at the connectathon, but what if that tests-runner branch isn't merged before then? Not a question we have to answer here and now)
Just for fun I also tested my CQL Decimal branch against the mitre-wip tests-runner, and got 1656 pass, 83 skip, 84 error. So once we get everything in flight all rebased and merged together the results should look even better
|
Thanks for the review. As you noticed, this should work against the runner's I will reach out to Bryn and ask him to prioritize cql-tests-runner#129 before the Connectathon. That has all the bug fixes we want. The cql-execution config file is less of a big deal. |
This PR contains the following CQL Test Server changes:
This brings us more in line with the Using CQL specification now that the CQL Tests Runner has fixed some of their bugs related to numeric interval representations.
If you'd like to manually test this, use the CQL Tests Runner mitre-wip branch:
cd test-serverthennpm run dev.mitre-wipbranch:./resultsfolder. My last run had 1639 passing, 83 skipped, 101 failed.Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
Submitter:
npm run checkto run tests, lint, and prettier)Reviewer:
Name: