Skip to content

CQL Test Server Updates - #377

Merged
cmoesel merged 1 commit into
masterfrom
test-server-updates
Aug 28, 2026
Merged

CQL Test Server Updates#377
cmoesel merged 1 commit into
masterfrom
test-server-updates

Conversation

@cmoesel

@cmoesel cmoesel commented Aug 26, 2026

Copy link
Copy Markdown
Member

This PR contains the following CQL Test Server changes:

  • Represent numeric intervals as Ranges
  • Fix range conversion bug for boundaries whose value is 0
  • Add default unit '1' to numeric range quantities
  • Update dependencies

This brings us more in line with the Using CQL specification now that the CQL Tests Runner has fixed some of their bugs related to numeric interval representations.

If you'd like to manually test this, use the CQL Tests Runner mitre-wip branch:

  1. Start the server on this PR's branch first: cd test-server then npm run dev.
  2. Run the following on the CQL Tests Runner mitre-wip branch:
    npm install
    git submodule update --init --recursive
    npx tsx src/bin/cql-tests.ts run-tests conf/cql-execution-local.json ./results
  3. Inspect the results in the test runner's ./results folder. My last run had 1639 passing, 83 skipped, 101 failed.

Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered.
  • Code passes lint and prettier (hint: use npm run check to run tests, lint, and prettier)
  • All dependent libraries are appropriately updated or have a corresponding PR related to this change
    Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

- Represent numeric intervals as Ranges
- Fix range conversion bug for boundaries whose value is 0
- Add default unit '1' to numeric range quantities
- Update dependencies
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.70%. Comparing base (81b47fc) to head (2ea1af7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          59       59           
  Lines        4933     4933           
  Branches     1429     1429           
=======================================
  Hits         4376     4376           
  Misses        322      322           
  Partials      235      235           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmoesel
cmoesel requested a review from dehall August 28, 2026 12:50

@dehall dehall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

I'm not super familiar with the tests-runner "ecosystem" so I confirmed this works better with the mitre-wip branch, but it still works with the current main. Or at least, nothing is obviously broken. (I know we're hoping to get a new cql-execution release out soon so that we can show off updated results at the connectathon, but what if that tests-runner branch isn't merged before then? Not a question we have to answer here and now)

Just for fun I also tested my CQL Decimal branch against the mitre-wip tests-runner, and got 1656 pass, 83 skip, 84 error. So once we get everything in flight all rebased and merged together the results should look even better

@cmoesel

cmoesel commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review. As you noticed, this should work against the runner's main branch too -- but there will be more failed tests because the main runner branch has some bugs in how it evaluates outputs. It also has an older cql-execution config file.

I will reach out to Bryn and ask him to prioritize cql-tests-runner#129 before the Connectathon. That has all the bug fixes we want. The cql-execution config file is less of a big deal.

@cmoesel
cmoesel merged commit 277d26f into master Aug 28, 2026
14 checks passed
@cmoesel
cmoesel deleted the test-server-updates branch August 28, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants