TS-47508 Accept a folder for the git-properties-jar option

[karottenreibe]

What

git-properties-jar now also accepts a folder, which is searched for git.properties files. Previously a folder was rejected with a warning and the option was dropped, so deployments that keep git.properties in a resources folder (e.g. /app/resources in a container image) instead of inside the profiled archive got no commit auto-detection at all.

How

The search machinery already handled both shapes: GitPropertiesLocatorUtils.findGitPropertiesInFile branches into an archive or a folder search, and the folder branch is what the automatic detection already uses for exploded class folders (BOOT-INF/classes, JBoss vfs temp folders). The obstacles were only:

• the !isFile() rejection in AgentOptionsParser.getGitPropertiesJarFile (now getGitPropertiesFileOrFolder), and
• the three call sites in AgentOptions hardcoding isJarFile = true, which now derive it from isDirectory(). ArtifactoryConfig.parseGitProperties got the corresponding parameter.

A non-existent path still logs a warning and lets the application continue.

Decisions

• Folder recursion semantics unchanged: the folder tree is always walked for git.properties, while search-git-properties-recursively only controls whether archives inside the folder are opened too. Making the flag also gate subfolders would change the existing automatic detection for exploded class folders, where git.properties usually sits in a subfolder — a breaking change with no upside here.
• Option name kept: no new alias and no deprecation, so an option named ...-jar now also takes a folder. Documented in the KDoc, the log messages and the CHANGELOG.

Drive-by fix

The inconsistency warning in GitSingleProjectPropertiesLocator pointed users at teamscale-git-properties-jar, which was replaced by git-properties-jar in 31.0.0. It now references the current option constant. The Artifactory "found no git.properties" message likewise named the deprecated artifactory-git-properties-jar.

Tests

• AgentOptionsTest.testGitPropertiesJarDoesNotAcceptFolders replaced by testGitPropertiesJarAcceptsFolders.
• DelayedCommitDescriptorRetrievalTest now covers both an archive and a folder search root.
• Folder scanning itself was already covered by GitPropertiesLocatorTest.testReadingGitPropertiesInJarFileNestedInFolder.
• ./gradlew :agent:test passes.

Manual verification against a real Teamscale/Artifactory upload is still pending.

Out of scope

Testwise mode error messages list git-properties-jar as a way to supply a commit, but no testwise code path reads gitPropertiesJar. That pre-existing gap is untouched.

🤖 Generated with Claude Code