codec2: restore legacy sync fence ABI - #54
Open
pbzin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_C2FenceFactory::CreateSyncFence(int)ABI.Root cause
Some Android 16 vendor Codec2 libraries still import the one-argument symbol. Without it, the vendor Codec2 service fails to load with a missing-symbol error, preventing video decoder initialization.
Compatibility
The overload delegates to
CreateSyncFence(fenceFd, true), so existing callers retain the current validation behavior while older vendor implementations regain binary compatibility.Validation
git diff --cached --checkpassed.This change is framework-generic and contains no Sapphire-specific blobs or device files.