Fix reconnect reliability and harden production security - #22
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
daredoole
marked this pull request as ready for review
August 5, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The client needed to recover from normal network/peer churn without manual intervention, while its build, test, release, and runtime controls needed a defensible production baseline.
Security boundary
The PowerToys compatibility protocol is legacy AES-256-CBC and does not provide authenticated integrity. This PR therefore documents and enforces a trusted-LAN/private-VPN deployment boundary; it does not claim the compatibility transport is safe on an arbitrary hostile network. The native Android relay uses AES-256-GCM with directional keys and ordered sequences.
Validation
Operational impact
Operators should expose the service only to a trusted LAN or private VPN, keep the firewall allowlist narrow, and release only through the signed-artifact production gate documented in
docs/production-security.md.