gtk4-prep: replace GtkWidget.destroy vfunc with GObject.dispose - #21545
Merged
Conversation
`GtkWidget.destroy` vfunc override is removed in GTK4. The migration guide recommends using `GObject.dispose` instead. Two custom widgets override the destroy vfunc: - `gradientslider.c`: `_gradient_slider_destroy` -> `_gradient_slider_dispose` - `range.c`: `_range_select_destroy` -> `_range_select_dispose` Both now implement `GObjectClass->dispose`, take `GObject *` parameter, and chain to `G_OBJECT_CLASS(parent_class)->dispose(object)`. Corresponds to the "Stop using the GtkWidget.destroy vfunc" section of the GTK4 migration guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GtkWidget.destroyvfunc override is removed in GTK4. The migration guide recommends usingGObject.disposeinstead.Two custom widgets override the destroy vfunc:
gradientslider.c:_gradient_slider_destroy->_gradient_slider_disposerange.c:_range_select_destroy->_range_select_disposeBoth now implement
GObjectClass->dispose, takeGObject *parameter, and chain toG_OBJECT_CLASS(parent_class)->dispose(object).Related: "Stop using the GtkWidget.destroy vfunc" #15920 #20433
https://docs.gtk.org/gtk4/migrating-3to4.html