ENH: add nunique delegation#861
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the remaining
nuniqueitem in #100.Summary
nuniquewrapper and backend dispatch into_delegation.pyunique(..., equal_nan=False)unique, while retaining the generic fallback for devices such asmetathat do not support data-dependent shapesThe
equal_nan=Falseargument preserves the existing Array API behavior where separate NaNs count as separate unique values.Validation
pytest -q -p no:cacheprovider: 4347 passed, 8984 skipped, 18 xfailed, 2 xpassedpytest -q -p no:cacheprovider tests/test_funcs.py::TestNUnique: 38 passed, 72 skipped in the lean environmentruff checkon changed filesruff format --checkon changed filesnumpydoc linton changed implementation modulesvalidate-pyproject pyproject.tomlCuPy could not be installed on this macOS host; its current native
uniquesignature was checked to supportequal_nanand CI covers the backend matrix.