acc: drop backend_default plan entries in UC comment tests - #6392
Open
janniklasrose wants to merge 2 commits into
Open
acc: drop backend_default plan entries in UC comment tests#6392janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
catalogs/comment_out_of_band and schemas/comment_out_of_band dump the plan change map via `bundle plan --output json | jq '.plan[].changes'`. On GCP the backend populates unity.catalog.managed.iceberg.defaults.delta.feature.catalogManaged on the fresh catalog/schema, which #5877's wildcard classifies as a backend default; it surfaces as an extra reason:backend_default skip in the plan. AWS and Azure do not populate it, so the committed golden diverged and the nightly failed on GCP only. Teach normalize_uc_payload.py to drop any reason:backend_default change entry (is_backend_default), generalizing the managed-defaults handling to the shape jq leaves once it strips the enclosing changes key, and pipe both tests through it so all clouds collapse to the real change. Local output is unchanged: the testserver only injects managed props for the fixed catalog_managed_defaults name, not the unique names these cloud tests use. Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
approved these changes
Aug 27, 2026
Collaborator
Integration test reportCommit: 1793972
Top 3 slowest tests (at least 2 minutes):
|
The first cut dropped every reason:backend_default change entry, which also stripped the deterministic storage_location backend default that volumes tests (volumes/uppercase-name, grants/volumes) show in their goldens, breaking local direct-engine acceptance. Only the managed-property change is cloud-divergent. Reuse is_managed_change and apply it at every level instead of only under a `changes` key, so it also fires on the top-level entry that jq '.plan[].changes' leaves behind. Plain backend defaults like storage_location are kept. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Teach
normalize_uc_payload.pyto drop anyreason:backend_defaultchange entry(
is_backend_default), generalizing the managed-defaults handling to the shapejqleaves once it strips the enclosing changes key, and pipe both tests through it so
all clouds collapse to the real change. Local output is unchanged: the testserver
only injects managed props for the fixed
catalog_managed_defaultsname, not theunique names these cloud tests use.
Why
catalogs/comment_out_of_bandandschemas/comment_out_of_banddump the planchange map via
bundle plan --output json | jq '.plan[].changes'. On GCP thebackend populates
unity.catalog.managed.iceberg.defaults.delta.feature.catalogManagedon the fresh catalog/schema, which #5877's wildcard classifies as a backend
default; it surfaces as an extra
reason:backend_defaultskip in the plan. AWS andAzure do not populate it, so the committed golden diverged and the nightly failed
on GCP only.
Tests
Ran against GCP cloud and it passed. Failed without the patch to
normalize_uc_payload.py.Co-authored-by: Isaac no-reply@databricks.com