ssh: move command group out of experimental into cmd/ssh - #6396
Open
TanishqDatabricks wants to merge 3 commits into
Open
ssh: move command group out of experimental into cmd/ssh#6396TanishqDatabricks wants to merge 3 commits into
TanishqDatabricks wants to merge 3 commits into
Conversation
Graduate the ssh command group out of experimental: - Move experimental/ssh/ -> cmd/ssh/. Command files are flattened up from the inner cmd/ subpackage into cmd/ssh/ directly (matching cmd/labs), and the internal/ tree moves to cmd/ssh/internal/, so `databricks ssh` lives alongside the other top-level command groups under cmd/. All import paths rewritten experimental/ssh/... -> cmd/ssh/... - Unhide the command (remove Hidden: true) so it appears in `databricks --help`. - Rename the CI test job test-exp-ssh -> test-ssh across the Taskfile task, tools/testmask (ciTargets + fixtures), the push.yml matrix job, and the pr-checklist skill. Drop the now-redundant ./experimental/ssh/... from TEST_PACKAGES (covered by ./cmd/...). - Update remaining path references (ruff.toml, libs cross-reference comments, moved docs) and add a .nextchanges/cli changelog fragment. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Approval status: pending
|
Two test fixes for the test-exp-ssh -> test-ssh rename and unhiding of the ssh command in the previous commit: - tools/testmask/targets_test.go: GetTargets returns alphabetically sorted targets, and "test-ssh" sorts after "test-pipelines"/"test-sandbox" whereas the old "test-exp-ssh" sorted before them. Reorder the expected slices in the "triggers all" cases to match; the string rename alone left them stale. - acceptance/help/output.txt: `databricks` root help now lists `ssh` under Additional Commands (it was hidden before), so add the entry. Co-authored-by: Isaac <no-reply@databricks.com>
ssh graduated out of experimental and is no longer hidden, so it can no longer illustrate the "top-level in cmd/cmd.go with Hidden: true" registration option. Point at `sandbox`, which still registers that way. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: de0b9a7
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the
sshcommand group out of experimental so it appears when a user callsdatabricks help.experimental/ssh/→cmd/ssh/. The command files are flattened up from the innercmd/subpackage intocmd/ssh/directly (matchingcmd/labs), and theinternal/tree moves tocmd/ssh/internal/, sodatabricks sshlives alongside the other top-level command groups undercmd/. All import paths rewrittenexperimental/ssh/...→cmd/ssh/....Hidden: true, sodatabricks sshnow shows indatabricks --help.test-exp-ssh→test-sshacross the Taskfile task,tools/testmask(ciTargets+ fixtures), thepush.ymlmatrix job, and the pr-checklist skill. Dropped the now-redundant./experimental/ssh/...fromTEST_PACKAGES(covered by./cmd/...).ruff.toml, cross-reference comments inlibs/processandlibs/testserver, and the moved docs..nextchanges/cli/ssh-out-of-experimental.md.Pure relocation + visibility change; no change to the command's behavior. Git tracked the whole tree as renames.
The CI check renamed from
task test-exp-ssh (...)totask test-ssh (...). If the old name is a required status check in branch protection, the required-check list must be updated or merges will block.Tests
task test-ssh(renamed) runs the ssh unit tests +TestAccept/sshacceptance tests.gofmtclean, no remainingexperimental/ssh/test-exp-sshreferences, and the testmask task↔ciTargets↔fixtures mapping is consistent. A fullgo build/test wasn't runnable in my environment (module proxy unreachable), so relying on CI to confirm the compile.This pull request and its description were written by Isaac.