Use source_code_path and git_source on Create/Update - #6399
Open
andrewnester wants to merge 2 commits into
Open
Conversation
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 4f489ac
Top 12 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use source_code_path and git_source on Create/Update
Why
For apps deployed with the direct engine,
source_code_pathandgit_sourceare now also sent as part of the Create/Update App request (in addition to the app Deploy API), so they are recorded on the app and drift-detected. The Terraform engine is unchanged (itsdatabricks_appresource cannot manage these input-only fields).Tests
Existing test cover the request body and pass