Skip to content

Use source_code_path and git_source on Create/Update - #6399

Open
andrewnester wants to merge 2 commits into
mainfrom
fix/app-source-code-path
Open

Use source_code_path and git_source on Create/Update#6399
andrewnester wants to merge 2 commits into
mainfrom
fix/app-source-code-path

Conversation

@andrewnester

@andrewnester andrewnester commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Changes

Use source_code_path and git_source on Create/Update

Why

For apps deployed with the direct engine, source_code_path and git_source are now also sent as part of the Create/Update App request (in addition to the app Deploy API), so they are recorded on the app and drift-detected. The Terraform engine is unchanged (its databricks_app resource cannot manage these input-only fields).

Tests

Existing test cover the request body and pass

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

29 files changed
Suggested: @denik
Also eligible: @shreyas-goenka, @janniklasrose, @pietern, @anton-107, @lennartkats-db

/bundle/ - needs approval

Files: bundle/config/resources/apps.go, bundle/deploy/terraform/tfdyn/convert_app.go, bundle/direct/dresources/app.go
Suggested: @denik
Also eligible: @shreyas-goenka, @janniklasrose, @pietern, @anton-107, @lennartkats-db

General files (require maintainer)

Files: .nextchanges/bundles/app-source-code-path.md, libs/testserver/apps.go
Based on git history:

  • @denik -- recent work in .nextchanges/bundles/, bundle/direct/dresources/, libs/testserver/

Any maintainer (@anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 4f489ac

Run: 33091550208

Env ❌​FAIL 🟨​KNOWN 🙈​SKIP ✅​pass 🙈​skip Time
❌​ aws linux 2 1 1 278 1192 12:57
❌​ aws windows 2 1 1 280 1190 17:02
❌​ azure linux 2 1 1 277 1192 11:39
❌​ azure windows 2 1 1 279 1190 14:22
❌​ gcp linux 2 1 1 278 1192 16:50
❌​ gcp windows 2 1 1 280 1190 20:24
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
🟨​ TestAccept 🟨​K 🟨​K 🟨​K 🟨​K 🟨​K 🟨​K
❌​ TestAccept/bundle/resources/apps/lifecycle-started ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
Top 12 slowest tests (at least 2 minutes):
duration env testname
5:06 gcp windows TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
5:00 gcp linux TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
4:47 gcp windows TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
4:44 gcp linux TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
3:21 aws linux TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
3:17 aws linux TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
3:13 aws windows TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
3:06 azure linux TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
2:55 azure linux TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
2:51 azure windows TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
2:51 azure windows TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
2:51 aws windows TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants