You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Detect symlinks to directories while walking bundle templates and return an actionable error before writing output. Add unit and acceptance coverage and a changelog fragment.
Why
bundle init treated a symlinked directory as a file, failed with an internal read error, and left a partial output directory behind. This change reports that symlinked directories are unsupported and avoids partial output. Fixes#6391.
Tests
go test ./libs/template
go test ./acceptance -run TestAccept/bundle/templates-machinery/symlinked-directory -v
./task fmt
./task lint
./task checks
./task test passed all 9,475 unit tests; the full acceptance run was blocked only by the unrelated existing bundle/templates-machinery/supported-url SSH timeout in this local network.
Files: .nextchanges/bundles/template-directory-symlink.md
Based on git history:
@denik -- recent work in .nextchanges/bundles/, libs/template/
Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Detect symlinks to directories while walking bundle templates and return an actionable error before writing output. Add unit and acceptance coverage and a changelog fragment.
Why
bundle inittreated a symlinked directory as a file, failed with an internal read error, and left a partial output directory behind. This change reports that symlinked directories are unsupported and avoids partial output. Fixes #6391.Tests
go test ./libs/templatego test ./acceptance -run TestAccept/bundle/templates-machinery/symlinked-directory -v./task fmt./task lint./task checks./task testpassed all 9,475 unit tests; the full acceptance run was blocked only by the unrelated existingbundle/templates-machinery/supported-urlSSH timeout in this local network.This PR was written with OpenAI Codex.