Improve AIR log retrieval reliability - #6414
Conversation
Integration test reportCommit: c9dc2cf
Top 3 slowest tests (at least 2 minutes):
|
29c379d to
6ba3037
Compare
cf199c8 to
12eb9b3
Compare
12eb9b3 to
ee3a5be
Compare
| @@ -0,0 +1 @@ | |||
| Improved AIR log fallback, retry-attempt selection, and Unity Catalog volume artifact handling. | |||
There was a problem hiding this comment.
I see a world where we don't have the MLflow artifact fallback but I'm not sure when bricklens will be stable so we should include it
| if volumeRoot, ok := volumeArtifactRoot(root); ok { | ||
| fc, err := filer.NewWorkspaceFilesClient(w, volumeRoot) |
There was a problem hiding this comment.
pls verify that NewWorkspaceFilesClient is what should be used for UC Volumes. I will stamp to unblock but make sure to verify.
There was a problem hiding this comment.
Verified: NewWorkspaceFilesClient was not the correct client for /Volumes/.... The CLI routes dbfs:/Volumes/... through filer.NewFilesClient in cmd/fs/helpers.go, and bundle volume uploads use the same client in bundle/libraries/filer_volume.go; FilesClient is the filer backed by the /api/2.0/fs Files API. I switched both AIR listing and download paths to NewFilesClient and updated the regression test to exercise the Files API. Focused UC Volume test, full experimental/air/cmd tests, and changed-file lint all pass. Fixed in a506832.
experimental/air is not surfaced in the public CHANGELOG; prior air PRs added no .nextchanges fragments. See .agents/rules/changelog.md and PR history. Co-authored-by: Isaac <no-reply@databricks.com>
3 participants
Changes
Why
Make AIR log streaming and downloads reliable across artifact backends, retries, and active runs.
Tests
go test ./experimental/air/cmdThis PR was written with Codex.