Remove unused default-sql versions.tmpl - #6420
Open
rugpanov wants to merge 1 commit into
Open
Conversation
The default-sql bundle template renders no cluster, so its library macros latest_lts_dbr_version and latest_lts_db_connect_version_spec are never referenced. The file contained only these two dead macros; remove it. Split out of the dbt-sql DBR bump (#6418) to keep that PR focused. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: edd9064
Top 3 slowest tests (at least 2 minutes):
|
rugpanov
marked this pull request as ready for review
August 28, 2026 09:23
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Delete
libs/template/templates/default-sql/library/versions.tmpl. Thedefault-sqlbundle template renders no cluster (it targets a SQL warehouse), so its two macros —latest_lts_dbr_versionandlatest_lts_db_connect_version_spec— are never referenced by any template. The file contained only these two dead macros.Split out of #6418 (dbt-sql DBR 16.4 bump) to keep that PR focused on a single change.
Tests
default-sqltemplate acceptance tests pass unchanged after the deletion.This pull request and its description were written by Isaac.