Add GCS download mode for Tennessee diabetes import - #2159
Merged
rohitkumarbhagat merged 3 commits intoAug 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a semi-manual GCS fallback mode to the Tennessee diabetes data importer, allowing files to be downloaded from Google Cloud Storage when TN.gov is blocked. It updates the README, adds a --download_source flag and GCS download logic to download.py, and introduces a new test suite in download_test.py. The review feedback correctly points out a potential compatibility issue with e.add_note(), which requires Python 3.11+ and could cause runtime errors in older environments.
ajaits
reviewed
Aug 14, 2026
ajaits
reviewed
Aug 14, 2026
ajaits
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--download_source=tn|gcsto the Tennessee diabetes downloader.Enable GCS mode in the import manifest.- last download from TN.gov passed. Keeping it default.Motivation
TN.gov blocks requests originating from Google Cloud environments. GCS staging provides a semi-manual fallback while preserving the existing processing flow.
Validation
The runtime service account requires
storage.objects.getaccess to theunresolved_mcfbucket.