Improve the style of the agent thinking card - #441
Open
pablonoel wants to merge 6 commits into
Open
Conversation
Introduce a pulsing background effects module and forward it from includes. Add a new IconStatusIndicator component with styles (SVG-mask conic gradients + spin) and wire it into the Status view. Extend Button API and styles to support a new 'huge' size. Update multiple page_home styles to use raised surfaces, muted borders, pulsing backgrounds, and layout/typography tweaks (prompt font, placeholder color). Adjust button sizes in Intro and FollowUp to use the new sizes. Minor layout tweaks to indicator/message alignment.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'huge' button size, a pulsing background effect, and a custom 'IconStatusIndicator' component, alongside visual updates to home page elements. The review feedback highlights several improvement opportunities: ensuring placeholder text colors remain distinct from typed input, using a robust border-radius approach for the 'huge' button to guarantee a pill shape, replacing a paragraph tag with a span to avoid layout issues from default margins, and using white instead of dark colors in SVG masks to prevent transparency issues in browsers defaulting to luminance mask mode.
- Add focus management and small UI tweaks on the home page: expose a textarea ref from PageHome to Prompt and autofocus the prompt input when status is hidden; autofocus the cancel button in Status on mount. - Add data-is-status-visible attribute and a fade transition to dim the prompt while status is visible. - Tweak status card spacing and padding (reduced gap and padding) and remove an unused tablet breakpoint rule.
- Adds useAutoFocus hook to centralize focusing behavior and use it in PageHome and Status. - Refactor pulsing-background into a parameterized mixin and add pulsing-card to share card shell styles used by intro, status, and follow_up. - Prevent prompt submission/focus while a status or follow-up panel is visible; wire disabled states for the prompt input and submit button. - Adjust button size styles for large/huge, tweak prompt typography, and simplify follow-up state handling in PageHome. - Minor SCSS cleanup and animation opt-outs.
- Remove the data-size="large" selector and simplify button SCSS so the pill border-radius applies consistently. - Update embedded SVG mask colors in status indicator SCSS from #231f20 to #ffffff to ensure correct masking/contrast. - Replace a block <p> with an inline <span> for the status text to avoid unintended spacing and improve layout.
pablonoel
marked this pull request as ready for review
August 14, 2026 12:27
pablonoel
requested review from
beets,
miss-o-soup and
nick-nlb
as code owners
August 14, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improves the style, behaviour and visual aspects of the agent thinking card, the focus flow, the intro and follow up cards. Adds new elements accordingly.
Related Issues
Fixes # (issue number)
Changes Made
New: Button huge size
New: IconStatusIndicator
New: pulsing-card effect (shared mixin)
Autofocus behavior
Prompt panel: disabled state while query runs
Button size bumps on existing call sites
new_thinking_card.mov
Testing Done
Describe the steps you took to test these changes (please also list commands ran if possible).
Checklist
Note: Only Maintainers can approve and merge PRs. Expected initial review time: 3 business days.