fix(portal): restore file parent folder after search preview back (IK5KDG) - #2255
Closed
likaiaki wants to merge 3 commits into
Closed
fix(portal): restore file parent folder after search preview back (IK5KDG)#2255likaiaki wants to merge 3 commits into
likaiaki wants to merge 3 commits into
Conversation
…5KDG) When opening a file from in-space search results, returning to the list now navigates to the file's parent folder instead of leaving the user on the wrong root or stale folder view. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Sidebar global search never set searchMode, so back stayed on 我的收藏. Track return space/parent, emit parent_id from file_level_path, and switch away from favorites into the file's containing folder. Co-authored-by: Cursor <cursoragent@cursor.com>
…5KDG) usePortalSpaces was bouncing activeSpace back to 我的收藏 when the target space was briefly missing from sidebar lists. Preserve the return target and navigate to the parent folder after the space switch settles. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npx jest src/pages/knowledge/portal/PortalKnowledgeWorkbench.test.tsx -t "returns from search preview" --no-watchman --coverage=falsenpx jest src/pages/knowledge/portal/PortalKnowledgeWorkbench.test.tsx -t "deep-link open with folderId returns" --no-watchman --coverage=falseGitee
Made with Cursor