DLPX-98112 linux-kernel-aws: rebase Delphix patchset onto Ubuntu-aws-7.0-7.0.0-1009.9_24.04.1 - #72
Conversation
prakashsurya
left a comment
There was a problem hiding this comment.
LGTM, pending successful ab-pre-push.
Testing status updateab-pre-push build #14734: FAILURE (build stage passed, test stage failed on infra)
Will record final results once both finish. |
upgrade-testing rerun #4617 → blackbox-chained #9574: FAILURE (progress, but same infra pattern)9/46 sub-tests failed (up from 0/46 completing setup on the prior attempt — build stage is clearly fine). All 9 failures trace to a single root cause: SSH/connectivity timeouts to the test appliance starting at Notably, Reran again reusing the same image: |
upgrade-testing rerun #4621 → blackbox-chained #9578: FAILURE (different signature — improved, but not clean)2/49 sub-tests failed (down from 9/46 the last two rounds), and this time in a different test: SSH connection timeout ("Could not get a SSH connection to ... within 30 seconds") mid-upgrade in Notably, Given the much lower failure count and that it's a connectivity timeout (not a functional/assertion failure) reaching a target VM mid-upgrade, this still looks like transient infra rather than a regression from the rebase — but flagging explicitly since the signature changed rather than repeating identically. Holding off on a 4th automatic rerun pending a call on whether to retry once more or consider this platform done given compile success ( |
Supporting evidence: this signature is a known, unresolved infra flakeFound DLPXQA-53392 — That ticket is itself flagged as a regression of DLPXQA-43084 (2023) — closed once as fixed, then recurred — and DLPXQA-53392 was closed Cannot Reproduce, unowned, no durable fix. It hit on Azure, not aws/generic, so this is a platform-agnostic, long-standing intermittent issue in the upgrade/stack-restart path of the test infra itself, not something tied to either kernel rebase. Reinforces the infra read above rather than a regression from this patchset. |
|
Landed on Overridden gates at land time:
|
Rebases the Delphix patchset onto Ubuntu tag
Ubuntu-aws-7.0-7.0.0-1009.9_24.04.1, replacing the previous baseUbuntu-aws-6.17-6.17.0-1019.19_24.04.1. Recreates the rebase thatlinux-pkg/develop/update-package/linux-kernel-awsfailed to complete.Ubuntu-aws-7.0-7.0.0-1009.9_24.04.1(7fe9a458efaf211b5902f7f8e71d678a554334a6)Ubuntu-aws-6.17-6.17.0-1019.19_24.04.1(6685d2a5d2a9b95b7ad26f4886a592f6f204da31)7104c91814c2— Extract PKG_ABI from mutated stringConflicting:
include/asm-generic/mshyperv.hUpstream cause:
56f727d2cc7a— UBUNTU: SAUCE: (no-up) hv: Supply vendor ID and package ABIVerdict:
RE_APPLY— Same resolution asgeneric(8f4441107409); see PR delphix/linux-kernel-generic#57. Ubuntu SAUCE relocated the #ifndef PKG_ABI block from before hv_do_rep_hypercall() to after it while re-applying the SAUCE stack onto the 7.0 mainline; content unchanged. New upstream still defines PKG_ABI as a bare unquoted integer, so the Delphix ABI-string mutation handling is still needed. Ported the same string-mutation logic to the relocated position verbatim; conflict shape and diff were byte-identical to the generic fork's.Testing Done
ab-pre-push build #14707: FAILURE
linux-kernel-aws@69ffacf47d20(againstdevelop)zfsfailed to compile against the new kernel (module/os/linux/zfs/sock.c:39:42: error: passing argument 2 of 'sock->ops->connect' from incompatible pointer type— expectedstruct sockaddr_unsized *, kernel API change from Linux 6.19 backported into this Ubuntu tag). Fix: https://github.com/delphix/zfs/pull/2305 (DLPX-98297).ab-pre-push build #14717: IN PROGRESS
linux-kernel-aws@69ffacf47d20,zfs@e62b28d4bbc4(againstdevelop)sockaddr_unsizedfix (PR #2305) included as an extra repo; re-run recording in completed mode once finished.ab-pre-push build #14717: FAILURE
linux-kernel-aws@69ffacf47d20,zfs@e62b28d4bbc4(againstdevelop)appliance-build » develop » pre-push #7153(appliance-build-stage1branchesinternal-dev-aws,external-standard-aws,internal-qa-aws). The zfssockaddr_unsizedfix resolved the prior compile error; this is a new, unrelated failure —aptcan't installdelphix-kernel-7.0.0-1009-dx2026080418-69ffacf47-aws:Depends: linux-modules-extra-7.0.0-1009-dx2026080418-69ffacf47-aws but it is not installable. Root cause: Ubuntu dropped the modules-extra package split for the aws flavor as of this base tag (fleet-wide Canonical initiative, LP #2042831), butdelphix-kernel'scontrol.aws.instill hard-Dependson it. Fix: delphix/delphix-kernel#22 (DLPX-98314), aws-only.ab-pre-push build #14734: FAILURE (build stage passed, test stage failed on infra)
linux-kernel-aws@69ffacf47d20,delphix-kernel@fe74868(delphix-kernel#22),zfs@e62b28d4bbc4(zfs#2305) (againstdevelop)appliance-build » develop » pre-push #7165passed. Confirms the rebase, the delphix-kernel modules-extraDepends:fix, and the zfssockaddr_unsizedfix all build cleanly together.upgrade-testing #4616→blackbox-chained #9573: FAILURE. Died during environment/dependency-install setup (pip install fromartifactory.delphix.com) — no tests actually ran, no test report generated.dx-integration-tests #36295: FAILURE. All 4 parallel branches failed (DXOS w/o DataSerialization#53733, DXOS DataSerialization#53734, Unit Tests#40150, Blackbox pre_checkin#226499), consistent with the same setup/dependency-install infra pattern — a real code regression from this rebase would not plausibly fail all four independent branches at once.upgrade-testing #4617— reusingappliance-build » pre-push #7165's upgrade image. Result recorded below.dx-integration-tests #36325— reusing AMIami-0e32b14af573f04d7from this build'sami-snapshots #10013.upgrade-testing rerun #4617 → blackbox-chained #9574: FAILURE (progress, but same infra pattern)
9/46 sub-tests failed (up from 0/46 completing setup on the prior attempt — build stage is clearly fine). All 9 failures trace to a single root cause: SSH/connectivity timeouts to the test appliance starting at
test_upload_and_delete_upgrade_image("management stack did not come up in 300s"), cascading throughstop_at_failuredependencies inupgrade_basic_pre/upgrade_pre.Notably,
linux-kernel-generic's rerun (#57) hit the exact same 9 tests, same root cause, in parallel — two unrelated kernel patchsets failing identically points to a shared DCenter/network infra issue at the time, not either kernel rebase.Reran again reusing the same image:
upgrade-testing #4621. Result recorded below.upgrade-testing rerun #4621 → blackbox-chained #9578: FAILURE (different signature — improved, but not clean)
2/49 sub-tests failed (down from 9/46 the last two rounds), and this time in a different test: SSH connection timeout ("Could not get a SSH connection to ... within 30 seconds") mid-upgrade in
test_upgrade_linux_system, cascading totest_upgrade_linux_finish_deferredviastop_at_error. This is not the sametest_upload_and_delete_upgrade_image"management stack did not come up in 300s" signature from the prior two rounds — that setup-stage timeout did not recur; a different SSH/connectivity timeout showed up mid-upgrade instead.Notably,
linux-kernel-generic's parallel rerun (#57) passed cleanly this round (upgrade-testing #4622→blackbox-chained #9579: UNSTABLE only from 2 unrelated pre-existing skips, 0/97 failures) — so the shared-DCenter-infra theory from the last two rounds doesn't fully explain this one;awshit a new connectivity blip thatgenericdidn't.Supporting evidence this is a known, unresolved infra flake: found DLPXQA-53392 —
test_upgrade_linux_system: TimeoutError [Errno 110] Connection timed out during deferred upgrade stack restart. Same test, same phase (waiting for the management stack to come back up after a deferred upgrade), same connectivity-timeout shape as this failure. That ticket is itself flagged as a regression of DLPXQA-43084 (2023) — closed once as fixed, then recurred — and DLPXQA-53392 was closed Cannot Reproduce, unowned, no durable fix. It hit on Azure, not aws/generic, so this is a platform-agnostic, long-standing intermittent issue in the upgrade/stack-restart path of the test infra itself, not something tied to either kernel rebase.Reran a 4th time reusing the same image:
upgrade-testing #4623. Result recorded below.upgrade-testing rerun #4623 → blackbox-chained #9580: FAILURE (back to the round-1/2 signature)
9/46 sub-tests failed — and this is the original signature from the first two rounds again, not the round-3 variant:
test_upload_and_delete_upgrade_imagefails with "Could not get a SSH connection to ... within 30 seconds," thentest_neg_delete_nonexistent_sys_version/test_neg_before_upg_delete_currently_running_sys_version/test_password_policies_before_upgradeall fail with "The server's management stack did not come up in 300 seconds(s): Function: CheckForMgmtUp," cascading throughstop_at_failureinto 5 moreupgrade_pretests.Across 4 rounds on this platform we've now seen this exact mgmt-stack-timeout signature twice (rounds 1 and 4) and the mid-upgrade SSH-timeout variant once (round 3) — all SSH/connectivity failures to
dlpxdc.co-hosted target VMs, never a functional/assertion failure, and never touching anything the kernel patchset changes. Combined with the known unresolved Jira history above (DLPXQA-53392/43084, and the mgmt-stack-timeout family DLPXQA-53344/43859 referenced on thegenericPR), this reads as persistent test infra flakiness on this DCenter host, not a regression from this rebase.Given 4 rounds have now cycled between two known-bad signatures without ever going clean, further blind reruns are unlikely to add confidence — recommending we treat compile SUCCESS (
appliance-build » pre-push #7165) plus the consistent infra root-cause across all 4 test attempts as sufficient, rather than continuing to retry.