Skip to content

feat(deploy): adding support for DENO_TIMELINE during pre-deploy - #3437

Merged
igorbdl merged 4 commits into
mainfrom
ib/predeploy-deno_timeline
Aug 4, 2026
Merged

feat(deploy): adding support for DENO_TIMELINE during pre-deploy#3437
igorbdl merged 4 commits into
mainfrom
ib/predeploy-deno_timeline

Conversation

@igorbdl

@igorbdl igorbdl commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@igorbdl
igorbdl requested a review from avocet-bot August 4, 2026 11:24
@avocet-bot

avocet-bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Avocet review status

State: Completed
Target: f073b3337fb9
Requested by: igorbdl
Model: Claude Opus
Attempt: 1 of 3
Updated: 2026-08-04T11:28:38.651Z
Formal review: #3437 (review)

The formal GitHub review is the authoritative result. This comment only reports operational status.

@avocet-bot avocet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review model: Claude Opus

Model verdict: APPROVE (informational only)

Formal review policy did not authorize an authoritative event (required_checks_missing).

Documentation-only change; accurate and internally consistent.

Verified: the env-var renames (DENO_DEPLOY_ORGANIZATION_*/_APPLICATION_*_ORG_*/_APP_*) are now consistent across builds.md, env_vars_and_contexts.md, and changelog.md with no stale long-form names remaining; CI=1CI=true matches builds.md's CI: true and leaves no CI=1 leftovers; and both added cross-links (/deploy/reference/env_vars_and_contexts/ and /deploy/reference/builds/) resolve to existing files. The new DENO_TIMELINE/pre-deploy wording is consistent with the per-timeline Deploy stage described in builds.md.

Non-blocking (pre-existing, untouched by this diff): env_vars_and_contexts.md:146 has a stray - This is a UUID. bullet, and DENO_DEPLOY_BUILD_ID is listed twice (lines 154 and 158) with differing descriptions.

No blocking findings.

@igorbdl
igorbdl merged commit c0627fe into main Aug 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants