feat(deploy): adding support for DENO_TIMELINE during pre-deploy - #3437
Conversation
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE (informational only)
Formal review policy did not authorize an authoritative event (required_checks_missing).
Documentation-only change; accurate and internally consistent.
Verified: the env-var renames (DENO_DEPLOY_ORGANIZATION_*/_APPLICATION_* → _ORG_*/_APP_*) are now consistent across builds.md, env_vars_and_contexts.md, and changelog.md with no stale long-form names remaining; CI=1 → CI=true matches builds.md's CI: true and leaves no CI=1 leftovers; and both added cross-links (/deploy/reference/env_vars_and_contexts/ and /deploy/reference/builds/) resolve to existing files. The new DENO_TIMELINE/pre-deploy wording is consistent with the per-timeline Deploy stage described in builds.md.
Non-blocking (pre-existing, untouched by this diff): env_vars_and_contexts.md:146 has a stray - This is a UUID. bullet, and DENO_DEPLOY_BUILD_ID is listed twice (lines 154 and 158) with differing descriptions.
No blocking findings.
Related to https://github.com/denoland/deployng/pull/3548