Skip to content

[Magento] cron:stop removes the wrong crontab block when previous_release is not the live release #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TuVanDev wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −2
Open

[Magento] cron:stop removes the wrong crontab block when previous_release is not the live release #4251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions recipe/magento2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,8 +593,18 @@ function magentoDeployAssetsSplit(string $area): void
*/
desc('Remove cron from crontab and kill running cron jobs');
task('magento:cron:stop', function () {
if (has('previous_release') && test("[ -f {{previous_release}}/{{magento_dir}}/bin/magento ]")) {
run('{{bin/php}} {{previous_release}}/{{magento_dir}}/bin/magento cron:remove');
// Magento keys each crontab block to the base path `cron:install` was run from
// (CrontabManager::getTasksBlockStart() appends hash('sha256', BP)), so `cron:remove` only
// removes the block of the installation it is run from. The block to remove therefore belongs to
// the release that is currently live, which is not necessarily {{previous_release}}: that is
// releases_list[1], so a release directory left behind by a failed deploy takes its place.
// Removing the wrong block leaves the live one in the crontab, and magento:cron:install then adds
// a second, leaving two cron:run entries running every minute.
//
// This task runs before deploy:symlink, so {{current_path}} is still the live release. __DIR__
// resolves the symlink, so BP is the real release path and the hash matches.
if (test("[ -f {{current_path}}/{{magento_dir}}/bin/magento ]")) {
run('{{bin/php}} {{current_path}}/{{magento_dir}}/bin/magento cron:remove');
}

run('pgrep -U "$(id -u)" -f "bin/magento +(cron:run|queue:consumers:start)" | xargs -r kill');
Expand Down