Prepare 1.0.1 cross-platform release support - #9
Merged
Conversation
Fix Windows portability, gate Windows and both macOS architectures in PR CI, and smoke-test every release archive before publication so unsupported assets cannot reach a GitHub Release.
Require the synchronized patch versions and explicitly bundle SQLite in the CLI so native macOS and Windows validation use the same database engine.
Resolve symlinked macOS temporary parents before SQLite NOFOLLOW opens while preserving final-file protection, and make filesystem edge-case tests native Windows compatible.
Compare the emitted artifact against the encoded native path so Windows backslashes and Unix separators validate the same public diagnostic contract.
Run the internal worker on an 8 MiB thread stack under Windows so extraction avoids the MSVC process default while retaining process-level supervision and resource limits.
Treat a peer reset during an oversized upload as a valid bounded rejection and verify the server remains healthy, covering kernels that close before reqwest finishes writing the request body.
Configure the MSVC csgraph binary with an 8 MiB main stack so the async command dispatcher and synchronous worker both have Unix-equivalent headroom.
Align the end-to-end budget diagnostic assertion with the lossless native path contract on Windows and Unix.
Validate exact encoded NativePath values instead of diagnostic display strings so the acceptance test preserves Windows and Unix path semantics.
Wait for the asynchronous HTTP task before testing cancellation and compare non-UTF-8 diagnostics with the platform-native artifact path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOFOLLOWprotection while supporting macOS's symlinked/vartemporary pathTest plan
cargo +nightly fmt --all -- --checkcargo +nightly clippy --workspace --exclude code-system-graph-fuzz --all-targets --all-features --locked -- -D warningscargo +stable test --workspace --exclude code-system-graph-fuzz --all-targets --all-features --lockedscripts/package-release.sh x86_64-unknown-linux-gnuscripts/smoke-install.sh dist/code-system-graph-x86_64-unknown-linux-gnu-v1.0.1Native CI evidence
All checks passed in CI run 30923368562, including the complete native Windows and both macOS suites.