feat: Add support for preserving pwsh history - #1708
Conversation
Kaniska (Kaniska244)
left a comment
There was a problem hiding this comment.
Thank you for the contribution. The tests are failing to get sudo access while executing the onCreate script you have added for non dev container origin base images.
This is happening because the lifecycle hooks such as onCreateCommand use the default container users to execute the commands and the dev container origin base images have a default user vscode configured with sudo access when isn't the case for other base images. Would you kindly optimize the solution accordingly?
|
Do you have an example |
The sample configuration is already present in If you have devcontainers/cli installed, you can use the following command for this with your changes. Even better, you can run it with debian trixie(13) basic Then if you try the dev container debian trixie(13) image |
… the file, it does not write error message into $PROFILE. Remove redundant `sudo` since this script is required to run as root
|
Kaniska (@Kaniska244) The two failures above seems to be unrelated reasons. Can you please double check |
If you scan the log, it's full of "permission denied" errors during test executions such as this. Could you please check? |
Kaniska (Kaniska244)
left a comment
There was a problem hiding this comment.
Replied on previous comment
…plicity setting the read permissions for any user
…s succeding so far because powershell does not complaing about missing var, it'll just not return anything.
|
Kaniska (@Kaniska244) Fixed. Also fixed the profile test, which would have always passed no matter if the profile was loaded or not. |
Kaniska (Kaniska244)
left a comment
There was a problem hiding this comment.
To be further reviewed by maintainers.
No description provided.