Updates for alpha-MC in FSPS - #393
Merged
Merged
Conversation
Add extra afe index to SSP arrays; Add afeindex and afe parameters and surface number of afe grid points; Update fsps/afe submodule to 3486349.
…ferent libraries.
for more information, see https://pre-commit.ci
…ip the weight*SSP and multi-z tabular tests since these modes are not yet available for the new afe dimension in FSPS >= 4.0
for more information, see https://pre-commit.ci
Collaborator
Author
|
Whoops, forgot to run the tests. A couple had to be skipped because the functionality is disabled for the alpha-enhanced models. I think this functionality is not often used, one is a private function. The LSF test now uses a much wider smoothing kernel given the low resolution of the new default spectral library. Also, the BaSeL isochrones were removed and the default libraries changed, so the options test was changed accordingly. |
Collaborator
Author
|
ok, was able to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates python-FSPS to work with FSPS v4.0, which had substantial internal source code and data file changes. Most of the existing driver routines have been tested to run at a basic level across multiple FSPS library combinations, including with alpha-enhancement. However, several methods are removed or disabled at present. These include:
_compute_csp()is now restricted tozcontinuous<= 1; larger values require more testing.interp_sspis disabled (though the underlying ztinterp fortran function works and is used elsewhere)_all_ssp_specis disabled.After this is merged it will probably be good to bump the version number, e.g. to v0.5.0, and make a new release.