Skip to content

fix: maintain valid state through the algorithm - #210

Open
john-halloran wants to merge 3 commits into
diffpy:mainfrom
john-halloran:logic-fix
Open

fix: maintain valid state through the algorithm#210
john-halloran wants to merge 3 commits into
diffpy:mainfrom
john-halloran:logic-fix

Conversation

@john-halloran

Copy link
Copy Markdown
Contributor

Previously the loose usage of "self.components_" was causing candidate components to be mixed with stored ones during a component update. This fix better matches MATLAB behavior and improves recovery, especially with a broader range of datasets that I previously hadn't tested with.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (d7586bc) to head (dfe0ce9).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   77.50%   82.00%   +4.50%     
==========================================
  Files           3        3              
  Lines          40       50      +10     
==========================================
+ Hits           31       41      +10     
  Misses          9        9              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably could use a test for the thing that broke that allowed you to find it in the first place, if you can engineer that. It would be a test that failed with the old code but passes with your current code fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants