Improve terminology and comments. - #57
Merged
davidlehn merged 3 commits intoJul 30, 2026
Merged
Conversation
davidlehn
commented
Jul 29, 2026
davidlehn
commented
Member
- Uses installed/built-in vs bundled/runtime. Seems clearer to me. Other suggestions welcome.
- The big comment was split up. Hopefully more understandable.
The code used "bundled" for the npm-installed undici and "runtime"/"native" for the one built into node, which reads backwards and made `bundledMajor === runtimeMajor` hard to follow. Standardize on "installed" and "built-in" throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The comment above `builtinFetchCompatible` had grown to explain the background, the constant, both branches, and the guarded version reads all at once. Hoist the background to a module-level note, leave the constant with only its own meaning, and move the note about `ky` forwarding `dispatcher` to the branch that relies on it. Drop the `Request` rebuild explanation, which `createFetch` already documents. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dlongley
approved these changes
Jul 29, 2026
dlongley
left a comment
dlongley
left a comment
Member
There was a problem hiding this comment.
I'm fine with this. An alternative to built-in might be platform.
Rename `builtinFetchCompatible` to `platformFetchCompatible` and `builtinMajor` to `platformMajor`, and update the comments to match. Also update the 4.3.1 changelog entry, which still used the older "bundled" and "runtime" wording for the same two things. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/undici-consistent-fetch #57 +/- ##
===============================================================
- Coverage 93.89% 93.85% -0.05%
===============================================================
Files 4 4
Lines 295 293 -2
===============================================================
- Hits 277 275 -2
Misses 18 18
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.