Skip to content

task-observer: deep-review updates from 2026-08-17 - #84

Open
divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-08-17
Open

task-observer: deep-review updates from 2026-08-17#84
divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-08-17

Conversation

@divad12

@divad12 divad12 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Target

skill: .agents/skills/deep-review/SKILL.md

Observations addressed

  • Observation 17 (journology/log.md): Review And Bug Learning Need Clear Global/Local Layers (deep-review portion) → changed: added guidance to the Learning Closeout section — when a review contract, checklist principle, or review process pattern applies across projects, route it to ~/dotfiles/docs/ai/ rather than only to a project-local docs/ai/ file; project-local docs should point to the global doc and add only project-specific deltas

Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bc9c9165e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +398 to +401
When a review contract, checklist principle, or review process pattern applies
across projects — not just to this codebase — route it to `~/dotfiles/docs/ai/`
rather than only to a project-local `docs/ai/` file. Project-local docs should
point to the global doc and add only project-specific deltas.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route global lessons through the learning store

When /deep-review runs in a project other than dotfiles, this closeout instruction directs it to write a cross-project lesson directly into a second repository's ~/dotfiles/docs/ai/ tree. That bypasses the canonical capture and promotion flow in docs/ai/learning-system.md (lines 10, 19, and 221), which stores evidence in docs/learnings/ and reserves global-doc changes for reviewed promotion, and can leave unrelated dotfiles changes outside the reviewed worktree. Capture the lesson in dotfiles' learning store first and let the dashboard/promotion step decide whether to update global guidance.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant