fix(update-consumers): exclude the action repos from discovery - #93
Merged
Conversation
The code-search query in update-consumers.yml contains the search pattern as a literal string, so discovery matched the action repo itself and the sed re-pin would have destroyed the query line in a self-addressed PR. Latent since the self-review caller moved to a local ref; caught by the first live dry run. Exclude both action repos from the discovery lines, mirroring the migrate-consumers guard.
ronan-thibaut-glitch
enabled auto-merge (squash)
August 25, 2026 09:15
Sayt-0
disabled auto-merge
August 25, 2026 09:15
ronan-thibaut-glitch
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first live dry run of
update-consumers.yml(run 32826389044, after #92) discovered the action repo itself as a consumer and showed a diff that would have mangled the workflow's own discovery query. This PR excludes the action repos from discovery.update-consumers.ymlcontainsdocker/docker-agent-action/.github/workflows/review-pr.yml@as a literal string, so the repo matches its own searchpr-review.ymlcaller,unique_by(.repo)picked that file (updated by #86 and earlier releases); since the rename toself-review-pr.yml, which calls the reusable workflow via a local ref (uses: ./.github/workflows/review-pr.yml, no@), the only remaining match in the repo is the query string itselfDry-run evidence
No writes were performed (dry run). The rest of the run was nominal: 49 repos routed (17 direct / 29 fork / 3 skip), 33 consumers flagged for the
actions: readtowritecaller bump.Validation
bash -non the extracted step script