fix(review-pr): fail closed on incomplete outcomes - #94
Open
Sayt-0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMENTevent and replaces approving language with the neutral🟢 NO FINDINGScompletion labelRoot cause
Several independent paths could present an incomplete run as successful:
job.statuswhilecontinue-on-errormasked review failuresBehavior
COMMENTwith### Assessment: 🟢 NO FINDINGSCOMMENTwithNEEDS ATTENTIONorCRITICALCOMMENTwithReview incomplete; no incremental checkpointCOMMENTwithVerification inconclusive; no incremental checkpointunverifiedSafety and compatibility
gh api, withevent: COMMENThardcodedAPPROVE,LGTM, andNo issues foundwording### Assessment:reviews compatible while rejecting the old synthetic LGTM fallback as an incremental checkpointpatternValidation
Model-backed eval outputs are intentionally kept outside the repository. No eval posted to a real pull request; GitHub posting behavior is exercised through the production shell harness with a mocked
ghendpoint.