Skip to content

docs: prune learnings section and tighten create-pr skill#25453

Merged
dvdksn merged 3 commits into
docker:mainfrom
dvdksn:worktree-prune-learnings-section
Jul 20, 2026
Merged

docs: prune learnings section and tighten create-pr skill#25453
dvdksn merged 3 commits into
docker:mainfrom
dvdksn:worktree-prune-learnings-section

Conversation

@dvdksn

@dvdksn dvdksn commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the unused Learnings/reflections section from the create-pr skill (the self-learning loop it fed was never used), adds optional guidance for Netlify deploy-preview entry paths and deep links on focused PRs, and tightens the branch/remote handling (default-branch guard, git status --porcelain clean-tree check, origin-vs-fork fallback, and a docs: title-prefix note).

Generated by Claude Code

dvdksn and others added 3 commits June 29, 2026 09:21
Drop the optional Learnings section and the PR learnings scanner
reference. The self-learning loop it fed was never used.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Document the optional @netlify entry-path stanza for focused PRs and
how to add deploy-preview deep links derived from the PR number.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Guard against running on the default branch (main/master)
- Use git status --porcelain to catch staged/unstaged changes, not
  just unstaged ones
- Handle the case where origin is upstream docker/docs by pushing to a
  separate fork remote, and derive FORK_OWNER from that remote
- Note the docs:/scope title prefix convention

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker failed. Why did it fail? →

Name Link
🔨 Latest commit 0843b4b
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a421f710a398e00078a083c

@dvdksn dvdksn added the status/review Pull requests that are ready for review label Jun 29, 2026
@dvdksn
dvdksn requested a review from a team June 29, 2026 07:32

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🔴 CRITICAL

One high-severity issue found in the new content introduced by this PR.

Comment thread .agents/skills/create-pr/SKILL.md
@dvdksn
dvdksn merged commit 1566bcf into docker:main Jul 20, 2026
14 of 18 checks passed
@dvdksn
dvdksn deleted the worktree-prune-learnings-section branch July 20, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants