docs: migrate virtual examples to TanStack Virtual - #55
Open
pupuking723 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses downshift-js/downshift#1654.
This migrates the existing
useComboboxanduseSelectvirtualization examples fromreact-virtualv2 to@tanstack/react-virtualv3. The integration remains in the examples repository, so Downshift itself does not gain a runtime dependency.The highlighted-index handlers now also ignore negative indexes before asking the virtualizer to scroll, which covers menu reset/close transitions.
Verification:
NODE_OPTIONS=--openssl-legacy-provider npm run buildpnpm dlx prettier@2.8.8 --check package.json src/hooks/useCombobox/react-virtual.js src/hooks/useSelect/react-virtual.jsgit diff --check