Surface OAuth2 error detail on token refresh (#420)#544
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 65.19% 65.19% -0.01%
==========================================
Files 34 34
Lines 65206 65205 -1
Branches 4642 4642
==========================================
- Hits 42509 42508 -1
Misses 22536 22536
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
30ee9c8 to
9ea949b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
raise_dropbox_error_for_resp: on a 400 from/oauth2/token, drop the redundantrequest_idre-fetch so refresh failures surface the server's error (e.g.invalid_client) as aBadInputErrorinstead of an opaque 400. Fixes the confusion in Problem with refreshing token #420.test_refresh_failure_error_detail— a wrong app secret must raiseBadInputErrorcarryinginvalid_client.SCOPED_USER_DROPBOX_TOKENfrom the required credentials and from ci.yml/coverage.yml.