Skip to content

bump node-version to 22 in workflows, add Node 22 to CI matrix, Update nock to v13 - #60

Open
cisco-annikiti wants to merge 1 commit into
masterfrom
fix_publish_node_version
Open

bump node-version to 22 in workflows, add Node 22 to CI matrix, Update nock to v13#60
cisco-annikiti wants to merge 1 commit into
masterfrom
fix_publish_node_version

Conversation

@cisco-annikiti

Copy link
Copy Markdown
Contributor

Description

Update Node version to 22 in CI and publish workflows, update nock to v13 for Node 22 compatibility, and add npm install -g npm@latest to publish workflow to support npm trusted publishers

Motivation and Context

The npm publish workflow was failing because trusted publishers requires npm 11.5+ and Node 22+. The workflow was on Node 12 which is EOL. Additionally, nock v9 had an incompatibility with Node 22's streams API

How Has This Been Tested?

Ran tests locally on Node 8, 10, and 22 - all 24 tests pass. Lint passes on Node 22

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cisco-annikiti
cisco-annikiti marked this pull request as ready for review August 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants