fix(envd): return error when concurrent /init races on NFS mount

[AdaAibaby]

When two concurrent /init requests race on isMountingNFS, the CompareAndSwap guard in setupNFS returns the named error value e, which is nil. The second caller proceeds as if NFS mounted successfully — sandbox starts with no volume mounts and no error surfaced to the caller.

Fix: return a package-level sentinel ErrConcurrentNFSInit so the caller receives a 500 and can retry. Using a sentinel (rather than fmt.Errorf) allows callers to match the error with errors.Is(), consistent with ErrAccessTokenMismatch and other sentinels in the same file.

Change

// before
if !a.isMountingNFS.CompareAndSwap(false, true) {
    logger.Debug().Msg("NFS volumes already mounting")
    return e  // nil — silent failure
}

// after
var ErrConcurrentNFSInit = errors.New("NFS mount already in progress")

if !a.isMountingNFS.CompareAndSwap(false, true) {
    logger.Debug().Msg("NFS volumes already mounting")
    return ErrConcurrentNFSInit
}

1 file, 2 lines changed.

/cc @ben-fornefeld @jakubno @dobrac @ValentaTomas @arkamar @tvi Looking forward to your code review.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac6364798c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eaba58c2a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".