fix(config): Tolerate malformed lines in the generated .env - #115
Merged
Conversation
Starting the app with make run died before Spring even began: DotenvException: Malformed entry <header documentation URL> The .env served by the external secrets manager carries a localized header, and some locales wrap the header's documentation URL onto a bare line without the leading comment mark. Docker Compose skips that line, but dotenv-java rejects it and spring-dotenv aborts the whole startup. The header generation is an upstream issue; on our side springdotenv.ignore-if-malformed now makes the loader skip non KEY=VALUE lines instead of failing, so every real variable still loads whatever the header locale looks like. Verified: the same environment that reproduced the exception boots to "Started LearnDevApplication", and the suite stays green (62 tests).
ebouchut
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #115 +/- ##
=========================================
Coverage 80.33% 80.33%
Complexity 186 186
=========================================
Files 38 38
Lines 783 783
Branches 42 42
=========================================
Hits 629 629
Misses 124 124
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Starting the app with
make rundied before Spring even began:Issue
The
.envserved by the external secrets manager carries a localizedheader, and some locales wrap the header's documentation URL onto a
bare line without the leading comment mark (
#).Docker Compose skips thatline, but dotenv-java rejects it,
and spring-dotenv aborts the whole startup.
The issue seems related to localization.
Workaround
The header generation is an upstream issue.
The workaround is to set
springdotenv.ignore-if-malformedtotrueto make the loader skipnon
KEY=VALUElines instead of failing, so every real variable still loads whatever the header locale looks like.Long Term Fix
Filed a ticket on the external secrets manager for this upstream issue to be fixed.