feat/site-logo - #121
Open
ebouchut wants to merge 2 commits into
Open
Conversation
The brand was text only. The header now carries an original geometric mark that reads as both an open book and code: two chevrons as the pages, a short center stroke as the spine. The mark is inline SVG rather than an img so stroke=currentColor can inherit the primary token and follow both themes automatically, including any future contrast retuning; an SVG referenced through img cannot see CSS custom properties. It stays aria-hidden with focusable false, so the visible text keeps being the accessible name of the brand link (RGAA 1.1). The brand anchor becomes an inline flex row to align mark and wordmark on their vertical centers. Refs #120
The site served no icon at all, so every browser session 404ed on favicon.ico. The mark now ships as a favicon in the standard trio: - favicon.svg, the source of truth; a tab icon cannot read the page theme tokens, so it adapts to dark tabs with an embedded prefers-color-scheme style hard-coding the two theme primaries - favicon.ico (16/32/48) for legacy clients, derived with rsvg-convert and ImageMagick, never edited by hand - apple-touch-icon.png (180x180) on an opaque theme-background tile, since iOS ignores transparency The head fragment lists the ico with a fixed size before the SVG so SVG-capable browsers prefer the scalable icon. Browsers fetch these root-level paths outside any page context, often anonymously, so the security filter chain permits them; the security matrix test pins that anonymous access down. An og:image social card stays out of scope until the app has a public canonical URL, as noted in the issue. Fixes #120
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #121 +/- ##
============================================
+ Coverage 81.57% 81.59% +0.02%
Complexity 201 201
============================================
Files 38 38
Lines 863 864 +1
Branches 53 53
============================================
+ Hits 704 705 +1
Misses 125 125
Partials 34 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a site logo:
aria-hidden=trueand `focusable=falseinline-flexto align mark and wordmark.favicon.svgwith embeddedprefers-colorcheme,favicon.ico(/32/48) for legacy,apple-touch-icon.pngx180 on opaque tileFixes #120