Skip to content

feat: needs.json merger - #733

Merged
a-zw merged 4 commits into
eclipse-score:mainfrom
etas-contrib:json
Aug 24, 2026
Merged

feat: needs.json merger#733
a-zw merged 4 commits into
eclipse-score:mainfrom
etas-contrib:json

Conversation

@AlexanderLanin

Copy link
Copy Markdown
Member

Summary

  • add a Bazel CLI to merge Sphinx-Needs needs.json inventories
  • validate input structure and reject conflicting Need definitions
  • write output atomically and preserve existing results on failure
  • add unit and Sphinx app-level coverage, including empty inventories
  • reuse public docs_bundle targets for test data instead of redundant source filegroups

Validation

  • bazel test //scripts_bazel/tests:merge_needs_json_unit_tests //scripts_bazel/tests:merge_needs_json_app_tests --test_output=errors
  • bazel build //scripts_bazel:merge_needs_json
  • commit hooks: Ruff, BasedPyright, copyright checks

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 0f089d50-0099-451d-a2d5-9c57fdbbb721
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 5.490s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-733: https://eclipse-score.github.io/docs-as-code/pr-733/

@AlexanderLanin AlexanderLanin changed the title feat: add production-ready needs JSON merger feat: needs.json merger Aug 20, 2026
Comment thread scripts_bazel/README.md
Comment thread scripts_bazel/tests/merge_needs_json_app_tests.py Outdated
@AlexanderLanin

Copy link
Copy Markdown
Member Author

discussed in call @AlexanderLanin @a-zw @MaximilianSoerenPollak: drop app tests, they will be executed implicitly in bundle tests soon

@a-zw
a-zw merged commit 61f51ea into eclipse-score:main Aug 24, 2026
14 of 17 checks passed
@a-zw
a-zw deleted the json branch August 24, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants