Skip to content

Fix: Resolve log bridge FFI stable compiler compatibility - #275

Open
ShoroukRamzy wants to merge 1 commit into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility
Open

Fix: Resolve log bridge FFI stable compiler compatibility#275
ShoroukRamzy wants to merge 1 commit into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility

Conversation

@ShoroukRamzy

@ShoroukRamzy ShoroukRamzy commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Unblock eclipse-score/inc_security_crypto#173
Solves eclipse-score/inc_security_crypto#185 and eclipse-score/inc_security_crypto#49

This PR resolves compiler compatibility crashes in ffi.rs when building @score_logging against modern stable Rust toolchains:

  • Explicit Array Sizes: Replaces deprecated placeholder underscores ([0; _]) with explicit numeric sizes (4 and 24) matching the declared struct layouts.
  • Explicit Namespace: Prefixes the from_utf8_unchecked call with the core:: namespace to resolve undeclared module errors.

Signed-off-by: sramzy1 <shorouk.ramzy@valeo.com>
@github-actions

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 1dfb9458-a3a6-4eb7-b591-da52f6d03498
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.10, but got score_crates@0.0.11 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 12.921s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @masc2023 and @OliverHeilwagen, this PR to remove the current logging patch in eclipse-score/inc_security_crypto#49.

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant