enable https for http things - #83
Conversation
Signed-off-by: Kirill Dorofeev <kirill.dorofeev@siemens.com>
|
Additionally to introducing https, the last commits are fixing the following deployment issues:
|
| "nosec_sc" | ||
| ], | ||
| "base": "http://localhost:3000/http-express-calculator-simple/", | ||
| "base": "https://localhost:3000/http-express-calculator-simple/", |
There was a problem hiding this comment.
This should probably be the plugfest domain?
There was a problem hiding this comment.
the TD for calculator is created dynamically from the TM https://github.com/eclipse-thingweb/test-things/pull/83/changes#diff-f6fcf5e47c6fd46a0258bc05e9715aee29fd6ebf1bc8bbb25c9ef067c862db04L93 This TD is actually not used at all, as far as I can see from the code.
There was a problem hiding this comment.
The TDs are actually only used for "documentation" purposes to statically provide them. Once the TDD integration happens automatically, we can simply link to the resources in the TDD.
| "title": "Counter", | ||
| "description": "Counter example Thing", | ||
| "support": "https://github.com/eclipse-thingweb/node-wot/", | ||
| "base": "https://localhost:3000/counter/", |
There was a problem hiding this comment.
Same as previous but now I am guessing if we should put both the local TD and the publically available one on github
There was a problem hiding this comment.
| limits: | ||
| cpus: "0.05" | ||
| memory: 50M | ||
| memory: 256M |
There was a problem hiding this comment.
just a question: Would it be better to NOT limit these and let docker automatically manage it?
Signed-off-by: Ege Korkan <egekorkan@gmail.com>
Signed-off-by: Ege Korkan <egekorkan@gmail.com>
31e1023 to
b61bcf9
Compare
…into feature/https Signed-off-by: Kirill Dorofeev <dorofeev@fortiss.org>
…into feature/https
Signed-off-by: Ege Korkan <egekorkan@gmail.com>
3 participants
make http thing advertise themselves as https