-
Notifications
You must be signed in to change notification settings - Fork 25
Keep ts-morph project reference between watches #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eddeee888
wants to merge
5
commits into
master
Choose a base branch
from
keep-project-reference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−17
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fac24f0
Keep ts-morph project reference for watched generation
eddeee888 6470312
Add changeset
eddeee888 4b806d3
Resync sourceFile content to avoid stale
eddeee888 4e161f1
Avoid overwriting content multiple times
eddeee888 1ffb026
Resync once
eddeee888 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@eddeee888/gcg-typescript-resolver-files': patch | ||
| --- | ||
|
|
||
| Keep ts-morph project reference between watches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,8 @@ import { logger } from './utils/index.js'; | |
|
|
||
| export const presetName = '@eddeee888/gcg-typescript-resolver-files'; | ||
|
|
||
| let tsMorphProject: Project; | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keeping a reference so we don't need to re-initialise and type-check files every run. |
||
|
|
||
| export const preset: Types.OutputPreset<RawPresetConfig> = { | ||
| buildGeneratesSection: async ({ | ||
| schema, | ||
|
|
@@ -88,10 +90,18 @@ export const preset: Types.OutputPreset<RawPresetConfig> = { | |
| moduleNamingMode, | ||
| }); | ||
|
|
||
| const tsMorphProject = await profiler.run( | ||
| async () => new Project(tsMorphProjectOptions), | ||
| createProfilerRunName('Initialising ts-morph project') | ||
| ); | ||
| if (!tsMorphProject) { | ||
| tsMorphProject = await profiler.run( | ||
| async () => new Project(tsMorphProjectOptions), | ||
| createProfilerRunName('Initialising ts-morph project') | ||
| ); | ||
| } else { | ||
| await profiler.run(async () => { | ||
| tsMorphProject | ||
| .getSourceFiles() | ||
| .forEach((sourceFile) => sourceFile.refreshFromFileSystemSync()); | ||
| }, createProfilerRunName('Refreshing ts-morph project files')); | ||
| } | ||
|
|
||
| const typeMappersMap = await profiler.run( | ||
| async () => | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was sitting outside of the intended scope so we were running
sourceFilesToProcess.forEachtwice! i.e. doubling the work