Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-papers-sit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eddeee888/gcg-typescript-resolver-files': patch
---

Set `overwrite.removeStaleFiles=false` (available in `@graphql-codegen/plugin-helpers` v7.2.0) to avoid scenario where resolver files are removed incorrectly.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@graphql-codegen/add": "7.1.0",
"@graphql-codegen/cli": "7.2.0",
"@graphql-codegen/near-operation-file-preset": "5.2.1",
"@graphql-codegen/plugin-helpers": "7.1.0",
"@graphql-codegen/plugin-helpers": "7.2.0",
"@graphql-codegen/schema-ast": "6.1.0",
"@graphql-codegen/typescript": "6.1.0",
"@graphql-codegen/typescript-react-apollo": "4.4.3-alpha-20260808101442-e439530add2acc6e119f54b148ccb537e4d0a7ec",
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-resolver-files/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"dependencies": {
"@eddeee888/gcg-server-config": "workspace:*",
"@graphql-codegen/add": "^7.1.0",
"@graphql-codegen/plugin-helpers": "^7.1.0",
"@graphql-codegen/plugin-helpers": "^7.2.0",
"@graphql-codegen/schema-ast": "^6.1.0",
"@graphql-codegen/typescript": "^6.1.0",
"@graphql-codegen/typescript-resolvers": "^6.1.0",
Expand Down
16 changes: 16 additions & 0 deletions packages/typescript-resolver-files/src/defineConfig.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ describe('defineConfig()', () => {
preset: defaultPreset,
presetConfig: {},
watchPattern: ['**/*.mappers.ts'],
overwrite: {
removeStaleFiles: false,
updateExistingFiles: true,
},
});
});

Expand All @@ -19,6 +23,10 @@ describe('defineConfig()', () => {
preset: defaultPreset,
presetConfig: {},
watchPattern: ['src/schema/**/*.mappers.ts'],
overwrite: {
removeStaleFiles: false,
updateExistingFiles: true,
},
});
});

Expand All @@ -30,6 +38,10 @@ describe('defineConfig()', () => {
presetConfig: {},
watchPattern: ['**/*.mappers.ts'],
schema: ['src/**/*.graphqls'],
overwrite: {
removeStaleFiles: false,
updateExistingFiles: true,
},
});
});

Expand All @@ -44,6 +56,10 @@ describe('defineConfig()', () => {
presetConfig: {},
watchPattern: ['**/*.mappers.ts'],
hooks: { afterAllFileWrite: ['prettier --write'] },
overwrite: {
removeStaleFiles: false,
updateExistingFiles: true,
},
});
});

Expand Down
10 changes: 9 additions & 1 deletion packages/typescript-resolver-files/src/defineConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const defineConfig = (
} = {}
): Pick<
Types.ConfiguredOutput,
'preset' | 'presetConfig' | 'watchPattern' | 'schema' | 'hooks'
'preset' | 'presetConfig' | 'watchPattern' | 'schema' | 'hooks' | 'overwrite'
> => {
const { schema, baseOutputDir = '', hooks } = context;

Expand All @@ -33,5 +33,13 @@ export const defineConfig = (
watchPattern,
schema,
hooks,
overwrite: {
// Server Preset needs to update existing resolver files
updateExistingFiles: true,
// When watching, it's common to avoid sending all files to Codegen to write to fs.
// When that happens, previously tracked files are marked as stale and gets removed wrongly.
// Therefore, we don't remove stale files.
removeStaleFiles: false,
},
};
};
23 changes: 19 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ allowBuilds:
unrs-resolver: true
minimumReleaseAgeExclude:
- '@graphql-codegen/typescript-react-apollo@4.4.3-alpha-20260808101442-e439530add2acc6e119f54b148ccb537e4d0a7ec'
- '@graphql-codegen/plugin-helpers@7.2.0'