refactor(link): extract link inline tool into standalone package - #161
Merged
Conversation
Unit Tests
Mutation Tests
|
Reversean
force-pushed
the
refactor/extract-italic-tool
branch
from
July 2, 2026 17:26
a934032 to
ee7f6ad
Compare
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
July 2, 2026 17:26
ddc6983 to
300592c
Compare
gohabereg
reviewed
Jul 6, 2026
Comment on lines
+25
to
+28
| | [`@editorjs/paragraph`](packages/tools/paragraph) | Built-in Paragraph block tool | | ||
| | [`@editorjs/bold`](packages/tools/bold) | Built-in Bold inline tool | | ||
| | [`@editorjs/italic`](packages/tools/italic) | Built-in Italic inline tool | | ||
| | [`@editorjs/link`](packages/tools/link) | Built-in Link inline tool | |
Member
There was a problem hiding this comment.
Probably better to add a separate section for tools/plugins
Contributor
Author
gohabereg
approved these changes
Jul 6, 2026
Reversean
force-pushed
the
refactor/extract-italic-tool
branch
from
July 6, 2026 20:12
ee7f6ad to
72864d1
Compare
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
July 6, 2026 20:14
300592c to
5cfdc1c
Compare
neSpecc
requested changes
Jul 13, 2026
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "@editorjs/link", | |||
Contributor
There was a problem hiding this comment.
we already have this package, and it is not inline-link, but embedded link block
Contributor
Author
There was a problem hiding this comment.
Renamed package name into @editorjs/inline-link.
neSpecc
approved these changes
Jul 13, 2026
Reversean
force-pushed
the
refactor/extract-italic-tool
branch
from
July 13, 2026 21:52
72864d1 to
fc084e7
Compare
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
July 13, 2026 21:52
c10eb3d to
a53e7bf
Compare
Reversean
force-pushed
the
refactor/extract-italic-tool
branch
from
July 13, 2026 21:53
fc084e7 to
5a3071a
Compare
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
July 13, 2026 21:53
a53e7bf to
01d481c
Compare
Move the built-in Link inline tool out of @editorjs/core into its own publishable package, @editorjs/inline-link, completing the split of all four built-in tools (paragraph, bold, italic, link) into independently versionable packages under packages/tools. This was the last tool living in core's internal tools folder, so the now-empty tools/internal directory is removed along with core's dependencies on @editorjs/dom and @codexteam/icons — both were only ever used by the tools that have now moved out.
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
July 13, 2026 21:58
01d481c to
9022c99
Compare
Reversean
enabled auto-merge
July 13, 2026 21:58
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+20
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Run ESLint check | ||
| uses: ./.github/actions/lint | ||
| with: | ||
| package-name: "@editorjs/inline-link" | ||
|
|
||
| build: |
Comment on lines
+21
to
+27
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Build the package | ||
| uses: ./.github/actions/build | ||
| with: | ||
| package-name: "@editorjs/inline-link" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@editorjs/coreinto its own publishable package,@editorjs/link, completing the split of all four built-in tools started with Paragraph.corenow depends on the new package as a workspace dependency, and no longer needs@editorjs/domor@codexteam/iconsdirectly (only the extracted tool packages use them now).Stacked on #160 (italic).