Enable the clippy::pedantic lint group - #255
Merged
Merged
Conversation
Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, like in emilk/egui#8429. Each opt-out carries its hit count, so the cost of turning one back on is visible. Lints that were already enabled one-by-one here stay on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
View snapshot changes at kitdiff |
emilk
added
the
exclude from changelog
emilk
marked this pull request as ready for review
August 18, 2026 08:57
rerun-sync Bot
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Aug 19, 2026
### Related Same pattern as: * emilk/egui#8429 * emilk/eframe_template#236 * emilk/egui_plot#255 * rerun-io/egui_table#63 * rerun-io/egui_tiles#155 * rerun-io/rerun_template#43 ### What Instead of opting in to pedantic lints one by one, enable the whole group in both the `rerun` and the `dataplatform` workspace, and opt out of the noisy ones. This deletes 91 explicit lint lines per workspace and picks up new pedantic lints for free. Each opt-out carries its hit count, so the cost of turning one back on is visible. `restriction` and `nursery` stay opt-in per lint. One commit per lint fixed. --------- Source-Ref: 9b69ee8f23610b9b427da62f8ab9f6cf782a9a3d Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, mirroring emilk/egui#8429.
Lints that were already enabled here one-by-one stay enabled, so this only adds coverage.
Each opt-out carries its hit count, so the cost of turning one back on is visible. The one new hit outside the opt-out list (
if_not_elseinspan.rs) is fixed here.