Add domainname configuration option#650
Merged
Merged
Conversation
Add domainname configuration option that defines the command to execute to fetch domain name that is set into the domainname state and which will be returned by "uname domain" modulefile command. Set to "domainname" by default. When configuration is modified it sets the MODULES_DOMAINNAME environment variable. Fixes envmodules#645 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Introduce the --with-domainname and --with-domainname-opts configure options to choose at installation time the default domainname command and its options to fetch domain. Default domainname is 'domainname' and its default options are ''. Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
xdelaruelle
force-pushed
the
domainname
branch
2 times, most recently
from
July 21, 2026 06:25
2ab504c to
880f47f
Compare
Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Do not check for the domainname command in configure script if --with-domainname option is not set. It preserves this way the behavior of previous Modules versions. Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
domainnameconfiguration option that defines the command to execute to fetch domain name that is set into thedomainnamestate and which will be returned byuname domainmodulefile command. Set todomainnameby default. When configuration is modified it sets theMODULES_DOMAINNAMEenvironment variable.